Fixes: kata-containers#1163

Signed-off-by: Wei Li <[email protected]>

- Do symlink to a relative path to hypervisor config.
- Create symlink on DESTDIR

Fixes: kata-containers#1161

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>

Config paths are set correctly but they must be set before handleShowConfig

fixes kata-containers#1185

Signed-off-by: Julio Montes <[email protected]>

Add a CODEOWNERS file so we can get github to automatically
request reviews. In this instance, specifically the docs team
for markdown documents.

Fixes: kata-containers#1192

Signed-off-by: Graham Whaley <[email protected]>

Architecture-dependent settings were not being populated when GOPATH
was set. This change ensures they are always set.

Fixes kata-containers#1169

Signed-off-by: William Douglas <[email protected]>

We are moving off pullapprove. Remove its config file.

Fixes: kata-containers#1215

Signed-off-by: Graham Whaley <[email protected]>

In GOPATH not set mode got:
make: go: Command not found
Makefile:38: arch/-options.mk: No such file or directory
make: go: Command not found
Makefile:237: *** "ERROR: No hypervisors known for architecture  (looked for: firecracker qemu)".  Stop.

The root cause is GOPATH not set mode is not set ARCH.
Set it to fix the issue.

Fixes: kata-containers#1224

Signed-off-by: Hui Zhu <[email protected]>

When a container does not exist, runc does not fail.  Lets mimic this
behavior, sometimes kuberentes will try to force delete containers that
could not be created and gets confused if delete --force fails.

Fixes: kata-containers#1219

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>

Sometimes qemu/qmp commands error out and VM files
get left behind on the host filesystem. Clen them up
irrespective of `stopSandbox` succeeds or fails.

Fixes: kata-containers#1246

Signed-off-by: Nitesh Konkar [email protected]

Commit affd6e3 ("devices: add reference
count for devices.") introduced an attach count for devices.  The
vhost-user-blk device increments the counter instead of decrementing it
when detaching.

Fixes: kata-containers#1259
Signed-off-by: Stefan Hajnoczi <[email protected]>

…o file

argument struct TestDataa in generic func genericTestGetCPUDetails is repeatedly
defined in almost all arch-dependent .go file, cli/kata-check_amd64_test.go,
cli/kata-check_ppc64le_test.go, etcm, except arm64. let's only declare it once in
cli/kata-check_test.go. change its name to testCPUDetail for better understanding.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

refine a set of test functions under qemu_arm64_test.go. e.g. test
func for memoryTopology shouldn't be the same one on amd64, since
for now, we don't support nvdimm on arm64.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

original tests for func RunningOnVMM are sort of amd64-specific,
since all other archs don't support nested VMM for now.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

since generic func genericAppendBridges and genericBridges
is also applied for machine type QemuVirt, we use it as implementation
for appendBridges and bridges on aarch64.
since const defaultPCBridgeBus is used in generic func
genericAppendBridges for pc machine, we should define it once
in generic file, instead of redefining it in different
arch-specific files.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

since all generic* could bring unused linter warnings, which lead to
CI crash, we add nolint comment to avoid them.

Fixes: kata-containers#1200

Signed-off-by: Samuel Ortiz <[email protected]>
Signed-off-by: Penny Zheng <[email protected]>

refine struct testData in func TestGetCPUDetails to remove redundant
/unused struct field expectedVendor and expectedModel

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>